Bug#888062: pocl: FTBFS on arm64: test_fabs and test_shuffle_{char,...,float} fail

[Aaron M. Ucko]

Source: pocl
Version: 0.14-5
Severity: important
Tags: upstream
Justification: fails to build from source
User: debian-***@lists.debian.org
Usertags: arm64
Gcc: "nnimap+Office 365:Sent Items"

Builds of pocl for arm64 have been failing, per the below excerpts from
https://buildd.debian.org/status/fetch.php?pkg=pocl&arch=arm64&ver=1.0-2&stamp=1516324314&raw=0

I acknowledge that the output I've quoted doesn't make the cause of
failure clear in these cases, but that's all the information I have.
Perhaps you can reproduce the errors on a porter box.

Could you please take a look?

Thanks!

----------------------------------------------------------------------

7/121 Test #22: kernel/test_shuffle_char ............................................................***Failed Required regular expression found.Regex=[OK

] 29.66 sec
OK



Start 28: kernel/test_shuffle_float
8/121 Test #23: kernel/test_shuffle_short ...........................................................***Failed Required regular expression found.Regex=[OK

] 34.67 sec
OK



Start 29: kernel/test_shuffle_long
9/121 Test #24: kernel/test_shuffle_ushort ..........................................................***Failed Required regular expression found.Regex=[OK

] 35.40 sec
OK



Start 30: kernel/test_shuffle_ulong
10/121 Test #25: kernel/test_shuffle_half ............................................................***Failed Required regular expression found.Regex=[OK

] 35.70 sec
OK



Start 31: kernel/test_shuffle_double
11/121 Test #26: kernel/test_shuffle_int .............................................................***Failed Required regular expression found.Regex=[OK

] 39.70 sec
OK



Start 2: kernel/test_as_type
12/121 Test #27: kernel/test_shuffle_uint ............................................................***Failed Required regular expression found.Regex=[OK

] 39.51 sec
OK



[...]
15/121 Test #28: kernel/test_shuffle_float ...........................................................***Failed Required regular expression found.Regex=[OK

] 40.82 sec
OK



[...]
29/121 Test #16: kernel/test_fabs ....................................................................***Failed Error regular expression found in output. Regex=[FAIL] 4.82 sec
CMake Error at /<<PKGBUILDDIR>>/cmake/run_test.cmake:22 (message):
FAIL: Test exited with nonzero code:
/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/tests/kernel/kernel;test_fabs


STDOUT:



STDERR:



-- OK

[...]
93% tests passed, 8 tests failed out of 121
[...]
The following tests FAILED:
16 - kernel/test_fabs (Failed)
22 - kernel/test_shuffle_char (Failed)
23 - kernel/test_shuffle_short (Failed)
24 - kernel/test_shuffle_ushort (Failed)
25 - kernel/test_shuffle_half (Failed)
26 - kernel/test_shuffle_int (Failed)
27 - kernel/test_shuffle_uint (Failed)
28 - kernel/test_shuffle_float (Failed)
Errors while running CTest

[Punit Agrawal]

Hi Aaron,

Post by Aaron M. Ucko
Source: pocl
Version: 0.14-5
Severity: important
Tags: upstream
Justification: fails to build from source
Usertags: arm64
Builds of pocl for arm64 have been failing, per the below excerpts from
https://buildd.debian.org/status/fetch.php?pkg=pocl&arch=arm64&ver=1.0-2&stamp=1516324314&raw=0
I acknowledge that the output I've quoted doesn't make the cause of
failure clear in these cases, but that's all the information I have.
Perhaps you can reproduce the errors on a porter box.
Could you please take a look?

There are two issues causing the test failure. I have a patch which
fixes one of the issues. More below...

[...]

Post by Aaron M. Ucko
7/121 Test #22: kernel/test_shuffle_char ............................................................***Failed Required regular expression found.Regex=[OK

The "Regex=[OK]" indicates that the test ran successfully and passed. But...

Post by Aaron M. Ucko
] 29.66 sec
OK

... upstream expects a subset of test_shuffle_* tests to fail. They
are marked as WILL_FAIL in the below excerpt from
tests/kernel/CMakeLists.txt

# interestingly, long/ulong/double do not fail
if(ARM64)
set_tests_properties("kernel/test_shuffle_char"
"kernel/test_shuffle_short" "kernel/test_shuffle_ushort"
"kernel/test_shuffle_uint" "kernel/test_shuffle_int"
"kernel/test_shuffle_float" ${HALF_TEST}
PROPERTIES
WILL_FAIL 1)
endif()

The attached patch (on top of the package repository) fixes it for me.

While investigating this failure, I noticed an unrelated issue with
the debian build for arm64 - instead of choosing a generic armv8 as
the target cpu, the rules file chooses to build with cortex-a53 (value
picked from debian/supported-arch). Just thought I'd mention it.

[...]

Post by Aaron M. Ucko
29/121 Test #16: kernel/test_fabs ....................................................................***Failed Error regular expression found in output. Regex=[FAIL] 4.82 sec
/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/tests/kernel/kernel;test_fabs
-- OK

This one seems to be an actual failure but the test code is a little
hard to parse. I'll try and see if I can figure out why it is failing.
In the meanwhile, please apply the attached patch as a partial fix.

Thanks,
Punit

[Aaron M. Ucko]

Post by Punit Agrawal
There are two issues causing the test failure. I have a patch which
fixes one of the issues. More below...

Great, thanks! FTR, this patch works for me too on the porter box
amdahl.debian.org.